gh: Fix 'if:' statement to avoid multiple uploads #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`actions/upload-artifact` will fail if we try to upload multiple times
the same artifact, which can happen in our setup with the matrix of go
versions:
```
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```
I tried to fix this before, but I got the `if:` condition wrong in the
workflow YAML file:
`if: matrix.go-version == '1.21.x'` should work better than `if: ${{ matrix.go-version }} == '1.21.x'`
Signed-off-by: Christophe Fergeau <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@jakecorrenti: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Christophe Fergeau <[email protected]>
|
/lgtm |
openshift-merge-bot
bot
merged commit c62637d
into
containers:main
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions/upload-artifactwill fail if we try to upload multiple timesthe same artifact, which can happen in our setup with the matrix of go
versions:
I tried to fix this before, but I got the
if:condition wrong in theworkflow YAML file:
if: matrix.go-version == '1.21.x'should work better thanif: ${{ matrix.go-version }} == '1.21.x'